-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hassio: Fix download snapshot #2071
Hassio: Fix download snapshot #2071
Conversation
_computeDownloadName(snapshot) { | ||
const name = this._computeName(snapshot).replace(/[^a-z0-9]+/gi, "_"); | ||
return `Hass_io_${name}.tar`; | ||
_downloadClicked() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No async function?
return `Hass_io_${name}.tar`; | ||
_downloadClicked() { | ||
this.hass | ||
.callWS({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this a helper function in auth/data.ts
(like the other functions in there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, ok to merge when addressed
Using the new
auth/sign_path
to generate a temp path.