Fix English only translations build

[steverep]

Proposed change

Fixes #21198. Task needs to better wait for English to be read and fragmented.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• Refactor
  • Improved stream handling in translation processes for better performance and simplified operations.

[coderabbitai]

Walkthrough

Walkthrough

The changes focus on improving the stream handling in the createTranslations function within the translations.js file. A new masterStream variable replaces certain gulp stream operations to enhance efficiency and reliability, addressing errors related to file handling during the build process, particularly the 'copy-static-app' error.

Changes

Files	Change Summary
build-scripts/gulp/translations.js	Replaced direct gulp stream operations with masterStream, added const masterStream = gulp, adjusted stream piping, and added completion handling for stream operations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Gulp
    participant masterStream
    participant hashStream
    participant FileSystem

    User->>Gulp: Start 'createTranslations'
    Gulp->>masterStream: Initialize masterStream
    masterStream->>hashStream: Pipe with { end: false }
    Gulp->>FileSystem: Create and manipulate translation files
    FileSystem->>masterStream: Notify completion
    masterStream->>Gulp: Finish 'createTranslations'
    Gulp->>User: 'createTranslations' finished

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Fix 'copy-static-app' errored due to missing translations output directory (#21198)	✅

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between d01377d and 200382b.

Files selected for processing (1)

• build-scripts/gulp/translations.js (1 hunks)

Additional comments not posted (3)

build-scripts/gulp/translations.js (3)

247-249: Good use of masterStream for improved readability.

The introduction of masterStream streamlines the stream operations and improves readability by separating the initial stream setup from subsequent operations.

---

250-250: Effective stream handling with masterStream.pipe(hashStream, { end: false }).

Including the .pipe(hashStream, { end: false }) operation within masterStream ensures that the hash stream is correctly piped without ending the stream prematurely, enhancing stream handling.

---

251-251: Improved handling of stream completion with mergesFinished.

Introducing mergesFinished as an array containing the result of finished(masterStream) ensures that the completion of stream operations is handled effectively, improving the overall process.

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.