Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min column size to 1 for vertical tile card #21275

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jul 3, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@coderabbitai ignore

Summary by CodeRabbit

  • Enhancements
    • Improved layout adaptability for the Tile Card, which now dynamically adjusts the minimum number of grid columns based on specific conditions.

This comment was marked as off-topic.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

src/panels/lovelace/cards/hui-tile-card.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about the ignore option but it is still reviewing. I don't think there is a way unless the config is changed like in core.

@piitaya piitaya added this to the 2024.7 milestone Jul 3, 2024
@piitaya
Copy link
Member Author

piitaya commented Jul 3, 2024

I edited the description. May be it must be set at the creation 🤷‍♂️

@piitaya piitaya merged commit 1ceef7c into dev Jul 3, 2024
13 checks passed
@piitaya piitaya deleted the tile-card-min-column-vertical branch July 3, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants