Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long press in FF #2226

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Fix long press in FF #2226

merged 2 commits into from
Dec 9, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 7, 2018

Test that TouchEvent exists before referring to it.

Fixes #2218

@ghost ghost assigned balloob Dec 7, 2018
@ghost ghost added the in progress label Dec 7, 2018
@balloob balloob mentioned this pull request Dec 7, 2018
Closed
@thomasloven
Copy link
Contributor

thomasloven commented Dec 7, 2018 •
edited

Wouldn't it be better to just check if ev.type is touchend or touchcancel?

I don't know what FF has instead of TouchEvent, but with this we risk missing it.

@balloob
Copy link
Member Author

balloob commented Dec 8, 2018

Sounds good.

@balloob
Copy link
Member Author

balloob commented Dec 8, 2018

Done.

@balloob balloob merged commit 2a23487 into dev Dec 9, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-long-press-ff branch December 9, 2018 09:09
@ghost ghost removed the in progress label Dec 9, 2018
@balloob balloob mentioned this pull request Dec 10, 2018
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomasloven thomasloven thomasloven approved these changes

Assignees

@balloob balloob

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.84.0b1 - LL TouchEvent is not defined
3 participants
@balloob @thomasloven @homeassistant