UI Editor for picture card
#2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
iantrich
force-pushed
the
picture-editor
branch
from
5bfb1a9
to
1afb770
Compare
balloob
reviewed
Dec 11, 2018
balloob
reviewed
Dec 11, 2018
iantrich
force-pushed
the
picture-editor
branch
from
f75cac5
to
e670654
Compare
balloob
reviewed
Dec 12, 2018
balloob
reviewed
Dec 12, 2018
|
Can we just drop service support from the UI editor for MVP ? |
balloob
reviewed
Dec 12, 2018
|
@balloob yes on the MVP. I'll add a note for the user for now. |
This is a WIP. * How should I handle service data? It's kind of freeform and I don't really have a good idea on what I should do. * in action-editor I have two issues for `_navigation_path` and `_service` have TS errors saying the property doesn't exist on `ToggleActionConfig`. Not sure why that is the only type it is looking at. Should I be checking the type somewhere?
This reverts commit 1e1a1e4.
iantrich
force-pushed
the
picture-editor
branch
from
8ec631f
to
e9ddd09
Compare
iantrich
changed the title
picture cardpicture card
|
@bramkragten for a future PR, would it make sense to use the |
balloob
reviewed
Dec 13, 2018
balloob
reviewed
Dec 13, 2018
balloob
reviewed
Dec 13, 2018
For an MVP maybe... We should just create a UI element for it that we can reuse for every card that uses |
bramkragten
reviewed
Dec 13, 2018
src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts
Outdated
Show resolved
Hide resolved
|
UI element for service data means we need to use the service descriptions available in |
balloob
reviewed
Dec 16, 2018
balloob
reviewed
Dec 16, 2018
src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Dec 18, 2018
src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts
Outdated
Show resolved
Hide resolved
balloob
approved these changes
Dec 18, 2018
|
Cool. I'll follow this same pattern for the other picture editors. Hopefully someone can come up with a clean way to handle service_data after those are done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP.
_navigation_pathand_servicehave TS errors saying the property doesn't exist onToggleActionConfig. Not sure why that is the only type it is looking at. Should I be checking the type somewhere?