Fix incorrect state display being cached #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
added a commit
that referenced
this pull request
Dec 19, 2018
* Fix incorrect state display being cached * Remove test for cache
Merged
|
This removes the ability to have an empty name. I will send a PR to re-allow it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI would render states before
this.hass.resourceswas loaded. This caused the rendering of the computed state domain to use the fallback value (the state) and cache that instateObj._stateDisplay. After resources were done loading, we didn't clear this cache and so users would see incorrect translated states until the state would change.This PR removes the caching in
stateObj._stateDisplayandstateObj._entityDisplay.This PR is best reviewed by ignoring whitespace
Fixes #2354
This might break some custom UI that was using the cache to inject their own values. With Lovelace there are now alternative ways to do this with possibilities to inject custom elements as entity rows, cards, views.
CC @andrey-git