Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon-apple-180x180.png #2385

Merged
merged 1 commit into from Dec 28, 2018
Merged

Update favicon-apple-180x180.png #2385

merged 1 commit into from Dec 28, 2018

Conversation

XusBadia
Copy link
Contributor

Updated webapp icon (apple-touch-icon) to a smaller size to better fit iOS design guidelines.

@homeassistant
Copy link
Contributor

Hi @XusBadia,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob
Copy link
Member

balloob commented Dec 27, 2018

There is no difference?

@balloob balloob closed this Dec 27, 2018
@ghost ghost removed the in progress label Dec 27, 2018
@XusBadia
Copy link
Contributor Author

The icon image should be slightly different (the logo is smaller).

@balloob
Copy link
Member

balloob commented Dec 27, 2018

Ah I see now, sorry for pressing close that quick. Can you show a before and after screenshot on iOS?

@balloob balloob reopened this Dec 27, 2018
@ghost ghost assigned balloob Dec 27, 2018
@ghost ghost added the in progress label Dec 27, 2018
@XusBadia
Copy link
Contributor Author

XusBadia commented Dec 28, 2018

Sure! Here's a close up comparison:

image

As you can see, the left one (current) is too close to the borders and the right one (new version) fits better inside the icon.

@balloob balloob merged commit f272801 into home-assistant:dev Dec 28, 2018
@ghost ghost removed the in progress label Dec 28, 2018
@balloob
Copy link
Member

balloob commented Dec 28, 2018

looks good 🎉 thanks

@iantrich iantrich added this to the 0.85 milestone Jan 2, 2019
@balloob balloob mentioned this pull request Jan 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants