Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be specific on Danish-Norwegian translation name #2468

Merged
merged 3 commits into from Jan 14, 2019

Conversation

odinho
Copy link
Contributor

@odinho odinho commented Jan 13, 2019

I noticed the names in the translation list was wrong. It says "Norsk" and "Norsk Nynorsk", when it should be "Norsk Bokmål" and "Norsk Nynorsk". In the context of language, there is two languages, "Nynorsk" and "Bokmål". There is no such thing as a written Norwegian language. "Norsk" would only be if it includes both "nn" and "nb". And since it is a translation, this is wrong. :)

@homeassistant
Copy link
Contributor

Hi @odinho,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@@ -91,7 +91,7 @@
"nativeName": "Norsk Nynorsk"
},
"no": {
"nativeName": "Norsk"
"nativeName": "Norsk Bokmål"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. According to ISO 639, no stands for Norsk. Norsk Bokmål would be country code nb.

https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So technically, the correct thing to do would be to add this change and also change the country code to be nb instead of no. But that would require an update of all Norwegian keys in our translation system 😱

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be the better fix. But it has wider reaching effects. Also might invalidate the users' already set-language if not "fixing" that on upgrade or some-such.

This is actually a very common problem in a lot of free software (probably proprietary as well) - since projects use no for Bokmål at the start which is technically wrong. 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I think I have been able to change it in lokalise from no to nb. So we will just change the key here. It's not the end of the world that some Norwegians have to pick a language again.

@ghost ghost assigned balloob Jan 14, 2019
@balloob balloob merged commit 8b19ea8 into home-assistant:dev Jan 14, 2019
@ghost ghost removed the in progress label Jan 14, 2019
@balloob balloob mentioned this pull request Jan 17, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants