New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be specific on Danish-Norwegian translation name #2468
Conversation
@@ -91,7 +91,7 @@ | |||
"nativeName": "Norsk Nynorsk" | |||
}, | |||
"no": { | |||
"nativeName": "Norsk" | |||
"nativeName": "Norsk Bokmål" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. According to ISO 639, no
stands for Norsk. Norsk Bokmål would be country code nb
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So technically, the correct thing to do would be to add this change and also change the country code to be nb
instead of no
. But that would require an update of all Norwegian keys in our translation system 😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be the better fix. But it has wider reaching effects. Also might invalidate the users' already set-language if not "fixing" that on upgrade or some-such.
This is actually a very common problem in a lot of free software (probably proprietary as well) - since projects use no
for Bokmål at the start which is technically wrong. 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I think I have been able to change it in lokalise from no to nb. So we will just change the key here. It's not the end of the world that some Norwegians have to pick a language again.
I noticed the names in the translation list was wrong. It says "Norsk" and "Norsk Nynorsk", when it should be "Norsk Bokmål" and "Norsk Nynorsk". In the context of language, there is two languages, "Nynorsk" and "Bokmål". There is no such thing as a written Norwegian language. "Norsk" would only be if it includes both "nn" and "nb". And since it is a translation, this is wrong. :)