YAML editor fixes #2737
Merged
YAML editor fixes #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Feb 12, 2019
| @@ -198,7 +198,7 @@ export class HuiEditCard extends LitElement { | |||
| if (!this._uiEditor) { | |||
| setTimeout(() => { | |||
| this.yamlEditor.codemirror.refresh(); | |||
| }, 1); | |||
| }, 50); | |||
There was a problem hiding this comment.
What is it that we're waiting for, and can we wait for that specifically? (like maybe this.updateComplete ?). Because it really depends on the speed of your computer/phone etc if 50 is going to be enough.
There was a problem hiding this comment.
I think we are waiting for the dialog to be resized... the update of the element itself is already complete...
|
Fixes #2723 |
bramkragten
force-pushed
the
yaml-editor-fixes
branch
from
f241ee6
to
d915483
Compare
balloob
reviewed
Feb 13, 2019
| setTimeout(() => { | ||
| this.yamlEditor.codemirror.refresh(); | ||
| }, 1); | ||
| afterNextRender(() => this.yamlEditor.codemirror.refresh()); |
There was a problem hiding this comment.
Suggested change
| afterNextRender(() => this.yamlEditor.codemirror.refresh()); | |
| afterNextRender(() => { this.yamlEditor.codemirror.refresh(); this._resizeDialog(); }); |
balloob
approved these changes
Feb 13, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.