Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position delete/move menu better for mobile #2738

Merged
merged 2 commits into from Feb 13, 2019
Merged

Position delete/move menu better for mobile #2738

merged 2 commits into from Feb 13, 2019

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Feb 12, 2019 •
edited

No description provided.

@ghost ghost assigned bramkragten Feb 12, 2019
@ghost ghost added the in progress label Feb 12, 2019
@balloob
Copy link
Member

balloob commented Feb 12, 2019

How does this change it?

@bramkragten
Copy link
Member Author

bramkragten commented Feb 12, 2019 •
edited

The menu was positioned outside of the screen partly on small screens, now it goes the other way, so always on the screen.

@bramkragten
Copy link
Member Author

Doesn’t fix the issue though, that is an iOS app thing...

@ghost ghost assigned balloob Feb 13, 2019
@balloob balloob merged commit 2ae30ac into dev Feb 13, 2019
@ghost ghost removed the in progress label Feb 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the position-card-options branch February 13, 2019 20:32
@balloob balloob mentioned this pull request Feb 13, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@balloob balloob

@bramkragten bramkragten

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bramkragten @balloob @homeassistant