Convert input-number to Lit/TS #2792
Conversation
Should I worry about width for the state display with slider?
ghost
assigned 
| <hui-generic-entity-row | ||
| .hass="${this.hass}" | ||
| .config="${this._config}" | ||
| id="input_number_card" |
There was a problem hiding this comment.
missed remnant from when width was being calculated
| } | ||
|
|
||
| private get _inputElement(): PaperInputElement { | ||
| return this.shadowRoot!.getElementById("input") as PaperInputElement; |
There was a problem hiding this comment.
This is not always true, as both have an ID set. I would instead just use querySelector('paper-input'), since we have just one.
There was a problem hiding this comment.
but only one will ever be rendered, the slider or the box
There was a problem hiding this comment.
Oh I see what you did there. Both have the same API so it works. I would suggest you just set the type to { value: string }
There was a problem hiding this comment.
Well, you say your return value is a PaperInputElement, but it might be that you are rendering a slider, so that's the wrong type. It only works because the parts of PaperInputElement that you access have the same API as PaperSliderElement. The overlapping part that you care about is { value: string }, so I suggest that you replace the return value and type casting (as) to { value: string }
There was a problem hiding this comment.
This is what linter wants me to do:
There was a problem hiding this comment.
yeah that's fine. just add a comment
* clientWidth not currently working * unsure about the typing of _InputElement
Should I worry about width for the state display with slider?
We previously has an IronResize and would hide it if the width went under 350