Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker: dynamic segmentation #2806

Merged
merged 10 commits into from Feb 26, 2019
Merged

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Feb 20, 2019

This PR adds a small button to the top left corner of the color picker wheel.
When this button is pressed the segmentation of the color wheel changes from the default: 24 hue segments and 8 saturation segments to a continues color wheel (360 hue segments and 255 saturation segments).
If the button is pressed again it changes back to the default (24 hue, 8 sat) and in this way you can keep togeling the color wheel segmentation.

I find this very helpfull because I love the default segmentation to be able to easily select full saturation and sync diffrent lights to exactly the same color.

However sometimes I want to discover new colors or just play around with my lights and then I like to be able to select all possible colors 360x255 instead of only 24x8 limited color possibilities.

segmented_color_wheel
full_color_wheel

@balloob
Copy link
Member

balloob commented Feb 20, 2019

sometimes I want to discover new colors or just play around with my lights and then I like to be able to select all possible colors

Sounds like an edge case. I don't think that this should be a toggle like this. Now that we have a permanent visible button for that, for which the user also expects that we store the settings between pages etc. I'm not a fan of options.

I don't know if or how we should expose it.

@starkillerOG
Copy link
Contributor Author

@balloob Thank you for your quick revieuw!
I just checked and the segmentation is actually saved between pages (vieuws) and between diffrent more-info cards of diffrent lights. It only resets to default (hue 24, sat 8) when you refresch the browser.

I really like having the ability to quickly switch between the segmentations and do think that I personally would use this quite often, My guess would be 30% of the times I actually use the color-picker (whenever I use the color-picker and not default scene's I often want to have full color control, now I switch back to the philips hue app or hyperion app were the color wheels are continues).

I could make the toggle-button smaller to make it more pleasant for the eye?

This button does not make the more-info card any bigger, because it is overlayed with the sqaure area taken up by the color picker (put on top of the right corner inside the padding of the round color picker but of course outside the actually useble area of the color-picker).

Maybe it is possible to do something like double click on the color wheel itself to switch eliminating the need for a visible button?
Although that would probably simaltaniously cause a color change and might be confusing for users?

I am totaly open for sugestions on diffrent ways to actuate the segmentation switching.

Schould this be discussed here in the PR, or do I need to do something else?

@starkillerOG
Copy link
Contributor Author

@balloob I made the icon smaller, placed in on the left side and alligned it with the icons for brightness and color temperature and chaged the color to match the other icons:
segmented_color_wheel_small_icon

Do you like this better or do you have any other suggestions?

@starkillerOG
Copy link
Contributor Author

@balloob how can I further improve this PR?

@balloob
Copy link
Member

balloob commented Feb 24, 2019

What is the use case for segments?

@starkillerOG
Copy link
Contributor Author

For segmentation (as it is now):

  1. beeing able to easily select "pure colors" (saturation 100%), otherwise jou have to hit exactly the edge of the continues color picker wich is very hard when using touch-screens such as phones. And on the other hand easily select pure white (255,255,255) in the center of the color picker.
  2. easily select the same color for diffrent lights and be able to select pure red, green or blue.

For continues color picker:

  1. being able to use the full capability of your lights instead of being restricted to 24 colors.
  2. Beeing able to select colors that are almost equal but just a bit diffrent tint to create nice mood lighting in a room (much like Philips Hue app uses its scenes like "Savanne" were all ligts are yellow to orange but all have a slightly diffrent color but do match very closely).

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cases sound ok. This whole modal is but ugly anyway, guess we can add this.

@starkillerOG
Copy link
Contributor Author

Thank you for looking into it again @balloob!
Can you also merge it?

@balloob balloob merged commit 6580d4c into home-assistant:dev Feb 26, 2019
@ghost ghost removed the in progress label Feb 26, 2019
@balloob
Copy link
Member

balloob commented Feb 26, 2019

lol, not sure what happened there, merged!

@starkillerOG
Copy link
Contributor Author

@balloob will this automatically also be merged to master to be in the next stable version of HomeAssistant, or do I have to make a PR to the master branch?

@arsaboo
Copy link
Contributor

arsaboo commented Feb 26, 2019

@starkillerOG It will automatically be merged in the next frontend release.

@starkillerOG
Copy link
Contributor Author

@arsaboo Thanks for the info!

@balloob balloob mentioned this pull request Feb 28, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants