Fixed arrow in sub-page to use new arrows and fixed new button icon issues #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Some pics before:
After it is fixed... |
balloob
reviewed
Feb 20, 2019
src/panels/lovelace/hui-editor.ts
Outdated
| @@ -60,6 +61,7 @@ class LovelaceFullConfigEditor extends LitElement { | |||
| class="save-button | |||
There was a problem hiding this comment.
To do this correctly, we should just put this inside the mwc-button tag. Solves RTL naturally
There was a problem hiding this comment.
Was already in there... We decided to move to text. Done
balloob
approved these changes
Feb 23, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're going to use this button a lot with icons we should wrap it and handle the issue internally.