Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert config flow to Lit/TS #2814

Merged
merged 5 commits into from Feb 24, 2019
Merged

Convert config flow to Lit/TS #2814

merged 5 commits into from Feb 24, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 21, 2019

Was planning to add area selection to the config flow dialog, but realized we should first get it to Lit/TS before making any other changes, so here we are 馃憤

@ghost ghost assigned balloob Feb 21, 2019
@ghost ghost added the in progress label Feb 21, 2019
iantrich
iantrich reviewed Feb 21, 2019
View reviewed changes
src/dialogs/config-flow/dialog-config-flow.ts
return html`
<paper-dialog
with-backdrop
.opened=${true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because people can click outside the dialog and that will set opened to false. We want the dialog to show as we will remove all DOM elements when there is nothing to show.

iantrich
iantrich reviewed Feb 21, 2019
View reviewed changes
Copy link
Member

@iantrich iantrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to finish reviewing tomorrow. I'm crazy tired and need sleep 馃槃

iantrich and others added 2 commits February 21, 2019 09:36
@iantrich @balloob
Apply suggestions from code review
3d8d23b 
Co-Authored-By: balloob <paulus@home-assistant.io>
@balloob
Add missing import
873dda1
iantrich and others added 2 commits February 23, 2019 17:23
@iantrich @balloob
Apply suggestions from code review
2045e4e 
Co-Authored-By: balloob <paulus@home-assistant.io>
@balloob
Address comments
fe3caa7
@balloob balloob merged commit 534b18e into dev Feb 24, 2019
@ghost ghost removed the in progress label Feb 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the convert-config-flow-lit branch February 24, 2019 04:35
@balloob balloob mentioned this pull request Feb 28, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iantrich iantrich iantrich left review comments

Assignees

@balloob balloob

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balloob @iantrich @homeassistant