馃Ч cleanup elements #2820
Merged
馃Ч cleanup elements #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Feb 22, 2019
|
|
||
| import computeStateName from "../../../common/entity/compute_state_name"; | ||
| import { LovelaceElement, LovelaceElementConfig } from "./types"; | ||
| import { HomeAssistant } from "../../../types"; | ||
|
|
||
| export interface Config extends LovelaceElementConfig { |
There was a problem hiding this comment.
I think that we should pick unique names for exported constants, so have StateBadgeElementConfig
There was a problem hiding this comment.
Go ahead and merge this one and I'll swing back around and do that for ALL configs
balloob
approved these changes
Feb 22, 2019
|
ill get these lint errors cleaned up |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.