Removed toast (entities turn on/off and OK service calls) #2822
Conversation
… called. Still will show on service error.
ghost
added
the
|
yeah, this is needed; but perhaps it should be configurable? |
|
Discussed with @balloob before implementation and was decided that opt in/out is not required. |
|
fine by me as long as you guys have considered it 👍 |
| const name = names.join(", "); | ||
| if (service === "turn_on" && serviceData.entity_id) { | ||
| message = this.hass.localize( | ||
| "ui.notification_toast.entity_turned_on", |
There was a problem hiding this comment.
Remove the translation strings too
|
I have been debugging for a while why this had vanished till I noticed this PR. |
|
Well it vanished because it is rarely useful and just makes the UI technical and not really simple user friendly. As for adding it back - @balloob ? |
|
We should not add it back globally. We can consider adding something back on a per-button case. |
|
Generally, switches you will see that they switch. We have also been adding |
|
I have a lot of scripts which send IR command's to TVs etc . They don't highlight when active. It was just nice to get some positive feedback that I had pressed the button and the command was sent. |
|
@gavinwoolley they are currently only available in the iOS companion app beta release (to my knowledge) |
Still will show on service error