Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ha-url-sync to TS #2824

Merged
merged 2 commits into from Feb 25, 2019
Merged

Convert ha-url-sync to TS #2824

merged 2 commits into from Feb 25, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 23, 2019

No description provided.

@ghost ghost assigned balloob Feb 23, 2019
@ghost ghost added the in progress label Feb 23, 2019
@balloob balloob mentioned this pull request Feb 23, 2019
Closed
5 tasks
iantrich
iantrich reviewed Feb 23, 2019
View reviewed changes
src/util/ha-url-sync.ts Outdated
}

if (!__DEMO__) {
customElements.define("ha-url-sync", HaUrlSync);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use decorator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't, it's conditional.

iantrich
iantrich reviewed Feb 23, 2019
View reviewed changes
src/util/ha-url-sync.ts Outdated Show resolved Hide resolved
iantrich
iantrich reviewed Feb 23, 2019
View reviewed changes
src/util/ha-url-sync.ts Outdated Show resolved Hide resolved
iantrich
iantrich reviewed Feb 23, 2019
View reviewed changes
src/util/ha-url-sync.ts Outdated Show resolved Hide resolved
iantrich
iantrich approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@iantrich iantrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after comments addressed

@balloob balloob merged commit 6d2e480 into dev Feb 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the ts-ha-url-sync branch February 25, 2019 19:11
@ghost ghost removed the in progress label Feb 25, 2019
@balloob balloob mentioned this pull request Feb 28, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iantrich iantrich iantrich approved these changes

Assignees

@balloob balloob

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balloob @iantrich @homeassistant