Convert ha-menu-button to TS #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
5 tasks
iantrich
reviewed
Feb 23, 2019
iantrich
reviewed
Feb 23, 2019
iantrich
reviewed
Feb 23, 2019
|
|
||
| // We are not going to use ShadowDOM as we're rendering a single element | ||
| // without any CSS used. | ||
| protected createRenderRoot(): Element | ShadowRoot { |
There was a problem hiding this comment.
does this gain us some performance?
There was a problem hiding this comment.
Yeah, creation of a shadow root has some overhead, because it's an isolated environment. Although I would not be able to give any numbers. Back in our Polymer 1 days, the polyfill was faster than using native ShadowDOM 😱
iantrich
approved these changes
Feb 23, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.