Convert map card to Lit/TS #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
iantrich
reviewed
Feb 23, 2019
| @property({ type: Boolean, reflect: true }) | ||
| public isPanel = false; | ||
|
|
||
| @property() |
There was a problem hiding this comment.
Can we decide on a standard for decorators? I don't like how we're doing inline sometimes but not always. I would vote for not inline as it is easier to be consistent and avoid long lines
There was a problem hiding this comment.
Well, prettier will put it on a new line if the property options get too long (as happened on the prop above this one).
iantrich
reviewed
Feb 23, 2019
iantrich
reviewed
Feb 23, 2019
iantrich
reviewed
Feb 23, 2019
iantrich
approved these changes
Feb 23, 2019
16 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.