Cleanup cards #2870
Merged
Cleanup cards #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I pulled this and every card seems to work, at least... |
balloob
reviewed
Mar 1, 2019
| static get styles(): CSSResult { | ||
| return css` | ||
| :host { | ||
| @apply --paper-font-body1; |
There was a problem hiding this comment.
We can remove this. This has never worked.
There was a problem hiding this comment.
@apply is a deprecated spec that Polymer supports, but will never become a standard.
balloob
reviewed
Mar 1, 2019
| } | ||
|
|
||
| .footer { | ||
| @apply --paper-font-common-nowrap; |
balloob
reviewed
Mar 1, 2019
| } | ||
|
|
||
| .box { | ||
| @apply --paper-font-common-nowrap; |
balloob
reviewed
Mar 1, 2019
| } | ||
|
|
||
| .header { | ||
| @apply --paper-font-headline; |
balloob
reviewed
Mar 1, 2019
| } | ||
|
|
||
| .header .name { | ||
| @apply --paper-font-common-nowrap; |
|
Going to rename all |
|
You can't just drop the You have to manually add everything they did, e.g. |
|
oh, derp |
https://github.com/PolymerElements/paper-styles/blob/v3.0.1/classes/typography.js I didn't find `paper-font-common-nowrap` in anything after v1.0.0 but did end up applying what I found here: https://chromium.googlesource.com/chromium/src/+/923ede74ebc57633583795a84b33e994f7dcd4fa/third_party/polymer/v1_0/components/paper-styles/typography.html
|
paper-styles should be copied over now |
|
🎉 !! |
This was referenced Mar 12, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.