Convert onboarding to Lit #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
4 tasks
|
We should allow password show clear text here (even set it as default). Because we don't have password_confirm field, if user either forget or have a typo in the password, he/she will have to redo on-boarding again. Of course, it is better than current situation, if user clicked |
|
That's a good point. We should do that for a future PR . Now that it's Lit, things will be easier. |
iantrich
reviewed
Mar 8, 2019
| class HaOnboarding extends litLocalizeLiteMixin(LitElement) { | ||
| public translationFragment = "page-onboarding"; | ||
|
|
||
| @property() private _name = ""; |
There was a problem hiding this comment.
are these not initialized if you set the type to string?
iantrich
reviewed
Mar 8, 2019
| "ui.panel.page-onboarding.user.required_field" | ||
| )}" | ||
| ></paper-input> | ||
|
|
There was a problem hiding this comment.
Add a password confirmation input and require the two fields to match
iantrich
reviewed
Mar 8, 2019
iantrich
reviewed
Mar 8, 2019
iantrich
reviewed
Mar 8, 2019
Co-Authored-By: balloob <paulus@home-assistant.io>
iantrich
approved these changes
Mar 8, 2019
|
I've added a password confirm. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires home-assistant/core#21777