Converted paper-dialog to ha-paper-dialog #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Apr 4, 2019
hassio/src/hassio-markdown-dialog.js
Outdated
| import "@polymer/paper-icon-button/paper-icon-button"; | ||
| import { html } from "@polymer/polymer/lib/utils/html-tag"; | ||
| import { PolymerElement } from "@polymer/polymer/polymer-element"; | ||
|
|
||
| import "../../src/components/ha-markdown"; | ||
| import "../../src/resources/ha-style"; | ||
| import "../../src/panels/lovelace/components/dialog/ha-dialog"; |
There was a problem hiding this comment.
this shouldn't be part of the lovelace components but instead be part of src/components and name should match the component: ha-paper-dialog.
There was a problem hiding this comment.
See my comment at the top. Knew you were going to say that...
balloob
reviewed
Apr 4, 2019
| @@ -428,7 +428,7 @@ export class HuiEditCard extends LitElement { | |||
| } | |||
|
|
|||
| @media (min-width: 1200px) { | |||
| paper-dialog { | |||
| ha-paper-dialog { | |||
There was a problem hiding this comment.
This seems weird. If there is no paper dialog on this page, we can remove this CSS Declaration ?
There was a problem hiding this comment.
balloob
approved these changes
Apr 4, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe ha-dialog should be placed in top level components folder. But that's going to be a lot of work...