New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service descriptions in zwave panel #306
Conversation
andrey-git
commented
Jun 17, 2017
•
edited
edited
- Add support for service descriptions in call buttons. Use it in Zwave panel.
- Don't capitalize attribute keys and values. For some data case might be important.
- Sort nodes by name and not by ID (might be different order if name customization is used)
@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob to be a potential reviewer. |
Is it possible to have the descriptions as mouseover descriptions? I think it looks a bit crowded. |
Mouseover doesn't exist on mobile :) I think the descriptions are important. When I added my last zwave node I decided to try out you panel. It worked. Then I added another node via dev-state service calls and set association so one will control the other. After a long time trying to understand why they don't talk to each other I noticed that the first device was included as secure. I'll look into adding a question mark button to toggle the descriptions on/off |
Question marks are a great idea. Have a look at the node information card. That has a toggle button to hide view text. |
@turbokongen Please take another look, I added some more changes to the PR. |
I'm unable to test this, because I'm out traveling for work. Just a few questions:
|
Now it is sorted by name. The help text appears for all service calls. |