Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service descriptions in zwave panel #306

Merged
merged 4 commits into from Jun 18, 2017

Conversation

andrey-git
Copy link
Contributor

@andrey-git andrey-git commented Jun 17, 2017

  • Add support for service descriptions in call buttons. Use it in Zwave panel.
  • Don't capitalize attribute keys and values. For some data case might be important.
  • Sort nodes by name and not by ID (might be different order if name customization is used)

zwave

@mention-bot
Copy link

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob to be a potential reviewer.

@andrey-git
Copy link
Contributor Author

@turbokongen

@turbokongen
Copy link
Contributor

Is it possible to have the descriptions as mouseover descriptions? I think it looks a bit crowded.

@andrey-git
Copy link
Contributor Author

Mouseover doesn't exist on mobile :)

I think the descriptions are important.

When I added my last zwave node I decided to try out you panel. It worked. Then I added another node via dev-state service calls and set association so one will control the other. After a long time trying to understand why they don't talk to each other I noticed that the first device was included as secure.

I'll look into adding a question mark button to toggle the descriptions on/off

@turbokongen
Copy link
Contributor

Question marks are a great idea. Have a look at the node information card. That has a toggle button to hide view text.

@andrey-git andrey-git changed the title Add service descriptions in zwave panel [WIP] Add service descriptions in zwave panel Jun 17, 2017
@andrey-git andrey-git changed the title [WIP] Add service descriptions in zwave panel Add service descriptions in zwave panel Jun 18, 2017
@andrey-git
Copy link
Contributor Author

@turbokongen Please take another look, I added some more changes to the PR.

@turbokongen
Copy link
Contributor

I'm unable to test this, because I'm out traveling for work. Just a few questions:

  1. The sorting, before, it sorted alfabetically by the zwave node entity_id how does it sort now ?
  2. The help text, is that show for all buttons in the card?

@andrey-git
Copy link
Contributor Author

Now it is sorted by name.

The help text appears for all service calls.

@balloob balloob merged commit 70da89a into home-assistant:master Jun 18, 2017
@andrey-git andrey-git deleted the zwave branch July 16, 2017 12:34
@bramkragten bramkragten mentioned this pull request Feb 12, 2020
tkdrob pushed a commit to tkdrob/frontend that referenced this pull request Apr 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants