Fix paper-icon-button fail #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I don't fully understand why it doesn't work, I just know that this will make it work 🤔
<paper-icon-button>usesiron-a11y-keys-behavior(we currently use 3.0.1) to support keyboard shortcuts. Something has happened with<paper-icon-button>, which prevents theiron-a11y-keys-behaviorregisteredcallback from being called. When the paper-icon-button is attached to the DOM and the key event listeners are attached, it misses the variable_keyBindingswhich is being initialized in theregisteredcallback.I tried rolling back versions of dependencies but was unable to get it working again. I think that this has been caused by the migration to Lit, but we haven't experienced it yet in the main frontend.
So to unblock things, just adding a placeholder variable 🤷♂️