Polymer 2 prepare #309
Merged
Polymer 2 prepare #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @justweb1, @andrey-git and @turbokongen to be potential reviewers. |
houndci-bot
reviewed
Jun 18, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
houndci-bot
reviewed
Jun 18, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
|
I have been playing with this, including in compiled mode and all still seems to work fine. Merging this. Note: this might require some custom UI to be updated to use slots instead of class names. |
Merged
tkdrob
pushed a commit
to tkdrob/frontend
that referenced
this pull request
Apr 20, 2021
* Add info about new widget and senor for android * Add info about newly added sensors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #308: the road to Polymer 2.
Note that after this PR, we are still running Polymer 1. However, since it's all hybrid 1 + 2 components, it should work when we switch to Polymer 2. Since there are some things handled differently this is not 100% smooth. After this PR is merged, the cycle will look like: update Polymer 2, find bug, fix bug in Polymer 1 branch. Once no more bugs under Polymer 2 -> switch 馃憤