Add support for secure devices pin #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't know this was a feature for GA. Nice! |
|
|
iantrich
reviewed
Apr 19, 2019
| alexa_enabled?: boolean; | ||
| google_allow_unlock?: boolean; | ||
| google_enabled?: CloudPreferences["google_enabled"]; | ||
| alexa_enabled?: CloudPreferences["alexa_enabled"]; |
There was a problem hiding this comment.
Shouldn't these be required if their CloudPreferences counter-parts are required?
There was a problem hiding this comment.
We only submit the preferences that we want to change when updating the prefs.
iantrich
approved these changes
Apr 19, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to set a pin to interact with secure Google Assistant devices
Backend PR: home-assistant/core#23223