Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha-card migration. Step #0: improvements to ha-card. #3144

Merged
merged 4 commits into from
May 7, 2019
Merged

Conversation

thomasloven
Copy link
Contributor

This improves the paper-card compatibility of ha-card and adds some extra interface improvements via named slots.

src/components/ha-card.ts Outdated Show resolved Hide resolved
src/components/ha-card.ts Outdated Show resolved Hide resolved
src/components/ha-card.ts Outdated Show resolved Hide resolved
src/components/ha-card.ts Outdated Show resolved Hide resolved
src/components/ha-card.ts Outdated Show resolved Hide resolved
src/components/ha-card.ts Outdated Show resolved Hide resolved
@thomasloven
Copy link
Contributor Author

For comparison

Headers on entities cards are slightly different. Most notably, they have the same height regardless of whether they have a toggle or not. Everything else should look the same as far as I can tell.

Before:
Skärmavbild 2019-05-04 kl  14 45 56

After:
Skärmavbild 2019-05-04 kl  14 46 27

Before:
Skärmavbild 2019-05-04 kl  14 52 56

After:
Skärmavbild 2019-05-04 kl  14 59 32

@balloob balloob merged commit 1223766 into dev May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the ha-card-conversion branch May 7, 2019 16:24
@balloob balloob mentioned this pull request May 8, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants