add target="_blank" to match all other links on page #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last three are hidden away in |
|
Thanks @thomasloven was having trouble finding those last three. |
|
Next hint: Travis fails due to formating errors. If you click "Details" to the right of the red cross below 👇 , you'll get its output. The important stuff starts at line 830. Otherwise, this looks good! |
|
Fighting prettier manually is tough. I just copy pasted the files locally, ran through prettier and pasted them back. Thanks Sean! |
|
Thanks @thomasloven & @robbiet480 for the helpful pointers and @balloob for taking it across the finish line after I got totally stumped on the |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that link opens in a new window rather than taking over the current one. All other links on this page have this attribute. See #3153 for more info.
This is my first ever PR here and I am inexperienced at Github so apologies in advance if I didn't do this correctly.