New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ha-card migration - step #2 #3187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thomasloven
force-pushed
the
ha-card-conversion
branch
from
May 10, 2019 10:25
0c3cfd6
to
3163b5e
Compare
thomasloven
force-pushed
the
ha-card-conversion
branch
from
May 10, 2019 10:46
f7cf177
to
e1a291b
Compare
store auth card is the modal at the bottom right asking users to store their login after logging in. |
Ah. That should not be converted then, I believe. |
overflow hidden is btw not a good thing to add to cards that do contain elements that require to overflow, like when they contain dropdowns or tooltips. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR CONTAINS UNTESTED CHANGES
I am currently unable to make sure the following parts looks ok:
If anyone tests it, please be on the lookout for ripple effects that go to the edge of the card. They need special treatment in order not to overflow rounded card edges.
The following still uses
paper-card
:dialogs/ha-store-auth-card
... whatever that is