Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha-card migration - step #2 #3187

Merged
merged 7 commits into from May 13, 2019
Merged

ha-card migration - step #2 #3187

merged 7 commits into from May 13, 2019

Conversation

thomasloven
Copy link
Contributor

@thomasloven thomasloven commented May 10, 2019

THIS PR CONTAINS UNTESTED CHANGES

I am currently unable to make sure the following parts looks ok:

  • zha configuration
  • zigbeee configuration
  • calendar panel
  • shopping list panel
  • gallery

If anyone tests it, please be on the lookout for ripple effects that go to the edge of the card. They need special treatment in order not to overflow rounded card edges.

The following still uses paper-card:

  • hassio - I won't touch this
  • legacy history graph card - Meh
  • dialogs/ha-store-auth-card... whatever that is

@thomasloven
Copy link
Contributor Author

thomasloven commented May 10, 2019

$ git grep "<paper-card"

hassio/src/addon-store/hassio-addon-repository.ts:              <paper-card
hassio/src/addon-store/hassio-repositories-editor.ts:            <paper-card>
hassio/src/addon-store/hassio-repositories-editor.ts:        <paper-card>
hassio/src/addon-view/hassio-addon-audio.js:      <paper-card heading="Audio">
hassio/src/addon-view/hassio-addon-config.js:      <paper-card heading="Config">
hassio/src/addon-view/hassio-addon-info.js:        <paper-card heading="Update available! 🎉">
hassio/src/addon-view/hassio-addon-info.js:        <paper-card heading="Warning: Protection mode is disabled!" class="warning">
hassio/src/addon-view/hassio-addon-info.js:      <paper-card>
hassio/src/addon-view/hassio-addon-info.js:        <paper-card>
hassio/src/addon-view/hassio-addon-logs.js:      <paper-card heading="Log">
hassio/src/addon-view/hassio-addon-network.js:      <paper-card heading="Network">
hassio/src/dashboard/hassio-addons.js:          <paper-card>
hassio/src/dashboard/hassio-addons.js:          <paper-card on-click="addonTapped">
hassio/src/dashboard/hassio-hass-update.js:            <paper-card heading="Update available! 🎉">
hassio/src/snapshots/hassio-snapshots.ts:          <paper-card>
hassio/src/snapshots/hassio-snapshots.ts:                <paper-card>
hassio/src/snapshots/hassio-snapshots.ts:                  <paper-card
hassio/src/system/hassio-host-info.js:      <paper-card>
hassio/src/system/hassio-supervisor-info.js:      <paper-card>
hassio/src/system/hassio-supervisor-log.js:      <paper-card>
src/cards/ha-history_graph-card.js:      <paper-card
src/dialogs/ha-store-auth-card.js:      <paper-card elevation="4">

@balloob
Copy link
Member

balloob commented May 10, 2019

store auth card is the modal at the bottom right asking users to store their login after logging in.

@thomasloven
Copy link
Contributor Author

Ah. That should not be converted then, I believe.

@balloob
Copy link
Member

balloob commented May 13, 2019

overflow hidden is btw not a good thing to add to cards that do contain elements that require to overflow, like when they contain dropdowns or tooltips.

@balloob balloob merged commit d99744e into dev May 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the ha-card-conversion branch May 13, 2019 08:24
@balloob balloob mentioned this pull request May 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants