Add support for and and or conditions to the automation editor.
#3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Sep 16, 2019
| } | ||
|
|
||
| public conditionChanged(conditions) { | ||
| if (this._mounted) { |
There was a problem hiding this comment.
Without this check, things do not work correctly, reproduction steps:
- Create a new automation
- Add a condition and set type to
and - Add two sub-conditions under the
andcondition, and populate them, for example
- Change type of the and condition to
or:
- Add a second sub-condition under the
orcondition - theorcondition is reverted back toand:
emontnemery
changed the title
and and or conditions in automationsand and or conditions to the automation editor.
balloob
approved these changes
Sep 23, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
andandorconditions to the automation editor.Screenshot:
