Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new action: url #3773

Merged
merged 4 commits into from Sep 22, 2019
Merged

new action: url #3773

merged 4 commits into from Sep 22, 2019

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Sep 19, 2019

Takes a url_path option.
Closes home-assistant/ui-schema#249

I'm experience the issue described here with my string values in the action-editor: #2645. Have not been able to track down where the issue is.

Anyone have any insight into the values not holding?
Thanks @bramkragten!!

Also closes #2645 now

Takes a `url_path` option.
Closes home-assistant/ui-schema#249
I'm experience the issue described here with my string values in the action-editor: home-assistant#2645. Have not been able to track down where the issue is.
Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge when documentation PR is made

@iantrich
Copy link
Member Author

@bramkragten any insight into the string values not re-populating in the action editor when re-opening the editor?

@bramkragten
Copy link
Member

@bramkragten any insight into the string values not re-populating in the action editor when re-opening the editor?

Yes, check this line:
https://github.com/home-assistant/home-assistant-polymer/blob/aa3b6343ed980a650b6840cf6b951658d3fdfd44/src/panels/lovelace/components/hui-action-editor.ts#L111
Should be:

    if (this[`_${target.configValue}`] === target.value)

@bramkragten bramkragten merged commit f871387 into home-assistant:dev Sep 22, 2019
@iantrich iantrich deleted the action-url branch September 23, 2019 18:07
@bramkragten bramkragten mentioned this pull request Oct 2, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Weblinks in Glance cards entity-button not retaining name of call-service
3 participants