Fix firefox overflow #3806
Merged
Fix firefox overflow #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIght fix...
balloob
reviewed
Sep 25, 2019
| flex: 1; | ||
| width: 100%; | ||
| flex: 1 1 100%; | ||
| max-width: 100%; |
There was a problem hiding this comment.
How does the page look with 1 column? Since the background is on this element, not having it be 100% will mess with the width ?
There was a problem hiding this comment.
base width is still 100%, it would be the same as:
flex: 1;
width: 100%;
max-width: 100%;
There was a problem hiding this comment.
but the flex-grow: 1 would also make it 100% width, so it should not be necessary at all
There was a problem hiding this comment.
CSS hell. Sometimes it's easier to just remove all rules and built it up again. Oh well.
We should start adding comments to CSS rules like this to make sure we know why they are there.
balloob
approved these changes
Sep 25, 2019
|
ok to merge when a comment is added, maybe even a reference to this PR. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix... #3725 & #3660