Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title option to stack cards #3839

Merged
merged 1 commit into from Oct 7, 2019

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Oct 1, 2019

@bramkragten
Copy link
Member

I think it looks a bit weird to have a header outside of a card...

@iantrich
Copy link
Member Author

iantrich commented Oct 1, 2019

Yeah, as do I, but I know people want it 🤷‍♀️

@bramkragten
Copy link
Member

We shouldn't just do anything people want, it will get a mess, let's think of a better way to do this. Isn't there a custom card that allows stacks in a card? Can't you add a title there?

@iantrich
Copy link
Member Author

iantrich commented Oct 2, 2019

I didn't mean to imply I didn't see it value in it; I meant I didn't see myself using it. I think it is a fine addition and something we should add.

@bramkragten bramkragten merged commit dcaf4fd into home-assistant:dev Oct 7, 2019
@iantrich iantrich deleted the stack-header branch October 30, 2019 03:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name/title for horizontal- and vertical stack
4 participants