Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where help icon overlapped with header text on mobile devices #3868

Merged

Conversation

pdong
Copy link
Contributor

@pdong pdong commented Oct 3, 2019

This fixes #3834

The headers are position relative and the help icons are position absolute to the top right.

This PR:

  • Adds a sectionHeader class to the headers on the zwave config panel (this seems consistent with other section headers that have class names)
  • Moves inline style to .sectionHeader
  • adds right padding to the sectionHeader so that the text will wrap before it runs into the icon (padding is same width as the help icon). This should work regardless of what the translation string is.
  • Adjusts the absolute positioning of the Zwave Node Management header's help icon to match the main header's positioning (it was sagging a bit). I'm guessing the text for this header should be moved to the the translation file

on iPhone X:
Before
image

After
image

Desktop after:
image

It was a struggle getting home assistant local dev setup and pointed to the front end. I wasn't able to fully get it pointed at my remote hass.io setup so sorry the screenshots are missing some of the node UI but that shouldn't affect the fixes (I did test the styles in-browser on my hass.io setup and it looks the same with addition of the extra cards.

@homeassistant
Copy link
Contributor

Hi @pdong,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! 👍

@bramkragten bramkragten merged commit 95b76db into home-assistant:dev Oct 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust CSS for help icon in Z-Wave panel on mobile devices
4 participants