Normalize longitude to the range between -180 to +180 degrees #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 6, 2019
| @@ -77,7 +77,9 @@ class LocationEditor extends LitElement { | |||
| } | |||
|
|
|||
| private _updateLocation(latlng: LatLng) { | |||
| this.location = this._ignoreFitToMap = [latlng.lat, latlng.lng]; | |||
| // Normalize longitude if map provides values beyond -180 to +180 degrees. | |||
| const longitude = (((latlng.lng % 360.0) + 540.0) % 360.0) - 180.0; | |||
There was a problem hiding this comment.
Can we only do this is the longitude is beyond -180 to +180?
if (Math.abs(latlng.lng) > 180) {
...
}
There was a problem hiding this comment.
OK, I'll add that.
bramkragten
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3793
Fixes home-assistant/core#26057
When fully zooming out of the map in the general configuration section, you will see multiple "versions" of the world's surface. When selecting a position outside the central version of the map, the longitude value will be smaller than -180º or greater than +180º which is wrong and won't be accepted by the HA backend's validator.
This change normalizes the longitude value received by the map.
The long form of the normalization would be to keep adding 360 to the value while it is smaller than -180º, or subtract 360 from the value while it is greater than +180º. The proposed code yields the same result in a single line.