Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double tap action #3879

Merged
merged 12 commits into from
Oct 16, 2019
Merged

Add double tap action #3879

merged 12 commits into from
Oct 16, 2019

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Oct 3, 2019 •
edited

Docs: home-assistant/home-assistant.io#10808

double_tap_action:
  action: more-info

@iantrich iantrich self-assigned this Oct 3, 2019
@iantrich
Copy link
Member Author

iantrich commented Oct 3, 2019

I want to revamp the action editor in another PR. Going to leave it off for now

@iantrich iantrich changed the title WIP Add double tap action Add double tap action Oct 3, 2019
@iantrich iantrich requested review from balloob and bramkragten and removed request for balloob October 3, 2019 19:36
bramkragten
bramkragten approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, to merge after comments

@iantrich iantrich mentioned this pull request Oct 15, 2019
Merged
2 tasks
@frenck
Copy link
Member

frenck commented Oct 15, 2019 •
edited

Just a quick usability thingy dbltap_action sounds sane, but it is abbreviated.
IMHO, we should avoid those abbreviations, it just makes it harder to understand for users less familiar with the system.

Suggestion: double_tap_action.

@iantrich
Copy link
Member Author

Yeah, I agree. I'll make the change

@iantrich iantrich merged commit df29a5b into home-assistant:dev Oct 16, 2019
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
Merged
@iantrich iantrich deleted the double-tap branch October 30, 2019 03:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob left review comments

@bramkragten bramkragten bramkragten approved these changes

Assignees

@iantrich iantrich

Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iantrich @frenck @balloob @bramkragten @homeassistant