add show_state option for picture-glance entities #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iantrich
changed the title
|
On |
|
I didn't personally like the look of a state under an icon that already relays the information; e.g. a light, but having it under the sensor did look good. So I agreed with @isabellaalstrom that it should be at the entity level |
|
Isn't that the same on |
|
I could introduce the option at the entity-level for glance as well if that's what you're getting at. Would leave the card-level option to avoid a breaking change and let the entity-level option override it. Could add the same to picture-glance. |
|
I would prefer that if we want it on entity level |
|
@bramkragten you see anything else on this one? Thanks. |
bramkragten
approved these changes
Oct 15, 2019
2 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the great work by @isabellaalstrom in #3321
Closes #3901
Docs: home-assistant/home-assistant.io#10916