New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide empty blocks on device page #3950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Oct 7, 2019
balloob
reviewed
Oct 7, 2019
balloob
reviewed
Oct 7, 2019
balloob
reviewed
Oct 7, 2019
balloob
reviewed
Oct 7, 2019
balloob
reviewed
Oct 7, 2019
bramkragten
added a commit
that referenced
this pull request
Oct 8, 2019
* Hide empty blocks on device page * lint * Rename entities on device rename * check if entity_id is valid * clarify var name * Review comments * Use regex to replace not allowed chars * Align with backend
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And added rename of entities when device is renamed... should have been in a separate PR but they would bite each other...