Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Toggle Editor button #3617 #3968

Merged
merged 1 commit into from Oct 9, 2019

Conversation

shmooey
Copy link
Contributor

@shmooey shmooey commented Oct 9, 2019

This fixes #3617 by changing the {} button to show "Show Visual Editor / Show Code Editor"

image

image

@bramkragten
Copy link
Member

I'm not sure Visual editor is the right word, not sure yet what is...

@Misiu
Copy link
Contributor

Misiu commented Oct 9, 2019

Maybe Show Default Editor or Show Form, because the form is the default editor 😄

@SeanPM5
Copy link
Contributor

SeanPM5 commented Oct 9, 2019

I think Visual editor makes sense.

People like my parents who aren't computer savvy wouldn't know what the heck a "UI editor" is but would understand the word "visual" and associate it with seeing what they're doing.

Plus I searched online and some other popular sites and services refer to it that way also. Wikipedia for example:

wikipedia

... and WordPress: https://en.support.wordpress.com/visual-editor/

Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's do it

@bramkragten bramkragten merged commit deeb014 into home-assistant:dev Oct 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle Editor is now named {} in UI.
6 participants