-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alarm Panel card: number buttons outline and adjusted padding and font-size fixing #2812 #3991
Alarm Panel card: number buttons outline and adjusted padding and font-size fixing #2812 #3991
Conversation
This comment has been minimized.
This comment has been minimized.
@@ -136,7 +136,7 @@ class HuiAlarmPanelCard extends LitElement implements LovelaceCard { | |||
@click="${this._handleActionClick}" | |||
outlined | |||
> | |||
${this._label(state)} | |||
<h1 style="font-size:16px;">${this._label(state)}</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style should not be inline
${value === "clear" | ||
? this._label("clear_code") | ||
: value} | ||
<h1 style="font-size:16px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use h1
inside a button, that's a header tag
I don't thing this looks good, let's keep all the font sizes normal, and just add a outline on the buttons. |
Okey, thought this could be a possible solution. I know it is not a good looking or very smart but it works, and help for people who is visual impaired. |
No problem, I can fix it. Just missed the raised part. Will push that change in one-two hours.
Best regards,
Marcus
… 14 okt. 2019 kl. 09:32 skrev Bram Kragten ***@***.***>:
I suggest this:
I can push my changes to your branch if you want?
Removing the base unit will make sure that the font sizes can scale when settings change. Not sure if it is possible to set font-size with a theme, but we might want to look into that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@bramkragten Sorry didn't read your whole post. Please push your changes! |
ah, nice find @bramkragten. That makes sense now. |
Thanks to @bramkragten for helping out.
Outline on buttons and less padding.
Found a solution for the font-size issue before mwc-button height bug is fixed.
fixes #2812