New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note about more integrations to bottom of Set up new integration dialog #3992
Conversation
@@ -79,6 +80,22 @@ class StepFlowPickHandler extends LitElement { | |||
` | |||
)} | |||
</div> | |||
<p style=${styleMap({ textAlign: `center` })}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use a styleMap
for static styles, they are for dynamic styles. Just add this styles to the static get styles()
<span> | ||
${this.hass.localize( | ||
"ui.panel.config.integrations.note_about_website_reference" | ||
)}<a href=${websiteLink} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just place the link inline instead of in a variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some small changes and it is good to go! 🦁
@@ -79,6 +80,22 @@ class StepFlowPickHandler extends LitElement { | |||
` | |||
)} | |||
</div> | |||
<p style=${styleMap({ textAlign: `center` })}> | |||
<span style=${styleMap({ display: `block` })}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A span
with display: block
, that's a p
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a line break <br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought that using them was not optimal but sure I can do that.
Hopefully a9ff740 addresses all your recommended changes :)
"ui.panel.config.integrations.note_about_integrations" | ||
)} | ||
</span> | ||
<span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why another span? This can all go straight in the p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🦁
Issues affected: #3951
Description:
<p>
to the bottom of the custom html element step-flow-pick-handler<span>
elements containing the note about more integrationssrc/translations/en.json
Result: