Allow device actions to specify extra fields #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 14, 2019
| } | ||
|
|
||
| public componentDidUpdate(prevProps) { | ||
| if (prevProps.action !== this.props.action) { |
There was a problem hiding this comment.
We should use the deviceAutomationsEqual function here (also on the others btw)
bramkragten
approved these changes
Oct 14, 2019
emontnemery
commented
Oct 14, 2019
| @@ -57,7 +66,7 @@ export const fetchDeviceTriggerCapabilities = ( | |||
| trigger, | |||
| }); | |||
|
|
|||
| const whitelist = ["above", "below", "for"]; | |||
| const whitelist = ["above", "below", "code", "for"]; | |||
There was a problem hiding this comment.
This might get a bit out of hand..
Maybe it would be better to pass the automation's extra_fields list to deviceAutomationsEqual instead?
There was a problem hiding this comment.
The problem is just that HaDeviceAutomationPicker doesn't know about the extra fields right now.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow device actions to specify extra fields which will then be shown in the UI using ha-form.
This is same as #3970 but for actions.