Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add actions to state-badge element and state-label-badge (default Lovelace badge type) #4028

Merged
merged 2 commits into from
Oct 21, 2019
Merged

add actions to state-badge element and state-label-badge (default Lovelace badge type) #4028

merged 2 commits into from
Oct 21, 2019

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Oct 16, 2019 •
edited

@iantrich iantrich self-assigned this Oct 16, 2019
@iantrich
Copy link
Member Author

will wait for home-assistant/home-assistant.io#10834 to be merged before adding docs

@bramkragten
Copy link
Member

How many places use HaStateLabelBadge? Rather have 1 logic instead of 2, either have them all handle the clicks themselves or have HaStateLabelBadge deal with it.

@iantrich
Copy link
Member Author

How many places use HaStateLabelBadge? Rather have 1 logic instead of 2, either have them all handle the clicks themselves or have HaStateLabelBadge deal with it.

Agreed

@iantrich
address comments
f71c45f 
state-label-badge no longer handles clicks
added actions to hui-state-label-badge
moved ha-badges-card to Lit
@iantrich
Copy link
Member Author

Went with a different approach and as suggested have the parent handling click events. I realized 3/4 the way through moving ha-badges-card to Lit that it was part of States, 🤷‍♂️

In doing this I also decided to add actions to badges 🎉

@iantrich iantrich changed the title add actions to state-badge element add actions to state-badge element and state-label-badge (default Lovelace badge type) Oct 18, 2019
@iantrich iantrich mentioned this pull request Oct 21, 2019
Merged
2 tasks
@iantrich iantrich merged commit c25a38b into home-assistant:dev Oct 21, 2019
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
Merged
@iantrich iantrich deleted the state-badge-actions branch October 30, 2019 03:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees

@iantrich iantrich

Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iantrich @bramkragten @homeassistant