Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot actions to be a list #4045

Merged

Conversation

pdong
Copy link
Contributor

@pdong pdong commented Oct 18, 2019

This resolves #4007

I moved the delete button to the bottom to match the mocks, moved labels to the buttons. I also removed the margin on paper-dialog-scrollable because it left a gap between the section name and the radio buttons compared to the other sections. I added a section name (Actions) at the bottom as the buttons looked a bit weird now that they were a list.

Before
image

After
image

@bramkragten
Copy link
Member

I think the text of the delete action should be the same color as the icon

@pdong
Copy link
Contributor Author

pdong commented Oct 18, 2019

Good point @bramkragten . I updated the text to also be the warning red color.

I initially tried to target it with mwc-button and the --mdc-theme-on-primary property but that didn't seem to do anything. Then I wanted to wrap both the icon and text in a container with a single warning class but that made the icon/text not line up. Eventually I found that wrapping just the text in a span with a warning class worked. 🤷‍♂

@bramkragten
Copy link
Member

You could put the warning class on the li?

@pdong
Copy link
Contributor Author

pdong commented Oct 18, 2019

Yeah I tried that. The text and icon are both the blue color in that instance.

@pdong pdong force-pushed the feat/update-snapshot-actions-to-buttons branch from f21e5c1 to eb4712e Compare October 19, 2019 05:17
@bramkragten bramkragten merged commit 4dbf532 into home-assistant:dev Oct 19, 2019
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hass.io available snapshots buttons - change to list format
4 participants