Add hovers (title attrs) to buttons on integrations config entry #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 19, 2019
src/panels/config/integrations/config-entry/ha-config-entry-page.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Oct 19, 2019
src/panels/config/integrations/config-entry/ha-config-entry-page.ts
Outdated
Show resolved
Hide resolved
pdong
force-pushed
the
feat/config-entry-button-titles
branch
from
b428075
to
631f0f8
Compare
bramkragten
approved these changes
Oct 20, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4047
Hovering over buttons:
Voiceover now reads what the button is instead of just button:
I'm assuming
configEntry.titleis safe to use as it is set as the panel header on L80 (.header=${configEntry.title}).