Changed button to text #4067
Merged
Changed button to text #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 20, 2019
src/resources/styles.ts
Outdated
Comment on lines
74
to
76
| .paper-dialog-buttons .warning.left-align { | ||
| margin-right: auto; | ||
| } |
There was a problem hiding this comment.
Move this to hui-edit-views static get styles(), there is a .delete class there that was used for the button, should clean that up and replace with the new styles.
bramkragten
reviewed
Oct 20, 2019
src/translations/en.json
Outdated
| @@ -502,6 +502,7 @@ | |||
| "common": { | |||
| "loading": "Loading", | |||
| "cancel": "Cancel", | |||
| "delete_view": "Delete View", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This should not be in common but in the section of lovelace and the views, there actually already is a key for delete there.
There was a problem hiding this comment.
@bramkragten I didn't realize those existed in en.json.
|
@bramkragten I have updated the PR with the styles being moved, and changing what the translation values are. |
bramkragten
approved these changes
Oct 21, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the trashcan icon to delete text.
Addresses feature #4027