Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added view title to heading of Lovelace Add Card picker #4083

Merged
merged 5 commits into from
Oct 22, 2019
Merged

Added view title to heading of Lovelace Add Card picker #4083

merged 5 commits into from
Oct 22, 2019

Conversation

springstan
Copy link
Member

@springstan springstan commented Oct 20, 2019 •
edited

Fixes #4029

Description:

  • removed heading from hui-card-picker.ts
  • added and updated translations key-value pairs for the Add Card picker heading in src/translations/en.json
  • updated the H3 heading in hui-dialog-edit-card.ts accordingly

Results:
withtitle
withouttitle

@springstan springstan mentioned this pull request Oct 20, 2019
Closed
@bramkragten bramkragten merged commit 11c08e9 into home-assistant:dev Oct 22, 2019
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweak heading of Lovelace Add Card picker
4 participants
@springstan @bramkragten @iantrich @homeassistant