Force rerender on update/save #4396
Conversation
src/panels/lovelace/hui-editor.ts
Outdated
| @@ -152,6 +155,9 @@ class LovelaceFullConfigEditor extends LitElement { | |||
| } else if (!this._changed && window.onbeforeunload) { | |||
| window.onbeforeunload = null; | |||
| } | |||
| if (this._changed) { | |||
| this.requestUpdate(); | |||
There was a problem hiding this comment.
Why do we need the requestUpdate?
There was a problem hiding this comment.
When I tested this, that was the best I could come up with, that is now a few days ago, I can probably do something different now to handle it, I'll have a look after work.
There was a problem hiding this comment.
_changed is a property, so if that is updated it should re-render?
There was a problem hiding this comment.
Should, yes.
does, not so much 🤷♂ (can be tested here https://demo.home-assistant.io/#/lovelace/0)
I can probably find a better way later today.
There was a problem hiding this comment.
Found a better way, looking at styles now
|
I think the disabled button needs a little styling, the text is very hard to read now. |
|
|
Changes
@property().Closes #4391
This also fixes an issue where the "Saved" and "Unsaved changes" were not showing.