Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ha-subppage toolbar css styles #4409

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

dcramer
Copy link
Contributor

@dcramer dcramer commented Jan 1, 2020

This addresses an issue with styling the toolbar in the same way that the app-header had been previously addressed.

This specific case can be reproduced by doing the following:

  • Set primary-color to a dark color (e.g. you want a dark header)
  • Open the notifications box, the links are dark (because they use primary-color for the anchor tags)
  • Switch primary-color to a light color, requiring you to redefine the app-header background color, and you'll find that most pages render as expected (other than HACS [already fixed upstream] and the integrations page, afaict)

@homeassistant
Copy link
Contributor

Hi @dcramer,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@dcramer
Copy link
Contributor Author

dcramer commented Jan 1, 2020

I'm not sure this is the right approach, but I'm new to the hass codebase and mostly just opened the PR to create a discussion around the best solution.

You'll see the behavior I'm trying to address by using the 'synthwave' theme from the HACS default repos.

@bramkragten bramkragten merged commit f0808c1 into home-assistant:dev Jan 2, 2020
@dcramer dcramer deleted the fix/toolbar-background branch January 2, 2020 19:58
dcramer added a commit to dcramer/synthwave-hass that referenced this pull request Jan 2, 2020
This binds the primary-color to be used primarily for text, and overrides app-header's background color (which defaults to primary-color). It resolves a few situations such as links in the notifications pullout, and with the upstream change, the toolbar on other pages.

See also home-assistant/frontend#4409
@bramkragten bramkragten mentioned this pull request Jan 7, 2020
@lock lock bot locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants