Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿ only set tabindex if tap_action defined #4511

Merged
merged 1 commit into from Jan 19, 2020
Merged

♿ only set tabindex if tap_action defined #4511

merged 1 commit into from Jan 19, 2020

Conversation

iantrich
Copy link
Member

fixes #4507

@iantrich iantrich self-assigned this Jan 18, 2020
balloob
balloob approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@balloob balloob merged commit 28511d0 into home-assistant:dev Jan 19, 2020
@iantrich iantrich deleted the action-tabindex branch January 21, 2020 03:56
@lock lock bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@bramkragten bramkragten Awaiting requested review from bramkragten

Assignees

@iantrich iantrich

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tabindex should only be defined if tap_action set
3 participants
@iantrich @balloob @homeassistant